Unverified Commit 0e2cebd7 authored by Shravan Kumar Ramani's avatar Shravan Kumar Ramani Committed by Ilpo Järvinen
Browse files

platform/mellanox: mlxbf-pmc: Use kstrtobool() to check 0/1 input 



For setting the enable value, the input should be 0 or 1 only. Use
kstrtobool() in place of kstrtoint() in mlxbf_pmc_enable_store() to
accept only valid input.

Fixes: 423c3361 ("platform/mellanox: mlxbf-pmc: Add support for BlueField-3")
Signed-off-by: default avatarShravan Kumar Ramani <shravankr@nvidia.com>
Reviewed-by: default avatarDavid Thompson <davthompson@nvidia.com>
Link: https://lore.kernel.org/r/2ee618c59976bcf1379d5ddce2fc60ab5014b3a9.1751380187.git.shravankr@nvidia.com


[ij: split kstrbool() change to own commit.]
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent f8c13117

drivers/platform/mellanox/mlxbf-pmc.c

+4 −6
Original line number Diff line number Diff line
@@ -1890,13 +1890,14 @@ static ssize_t mlxbf_pmc_enable_store(struct device *dev, 
{

	struct mlxbf_pmc_attribute *attr_enable = container_of(

		attr, struct mlxbf_pmc_attribute, dev_attr);

	unsigned int en, blk_num;

	unsigned int blk_num;

	u32 word;

	int err;

	bool en;



	blk_num = attr_enable->nr;



	err = kstrtouint(buf, 0, &en);

	err = kstrtobool(buf, &en);

	if (err < 0)

		return err;
@@ -1916,14 +1917,11 @@ static ssize_t mlxbf_pmc_enable_store(struct device *dev, 
			MLXBF_PMC_CRSPACE_PERFMON_CTL(pmc->block[blk_num].counters),

			MLXBF_PMC_WRITE_REG_32, word);

	} else {

		if (en && en != 1)

			return -EINVAL;



		err = mlxbf_pmc_config_l3_counters(blk_num, false, !!en);

		if (err)

			return err;



		if (en == 1) {

		if (en) {

			err = mlxbf_pmc_config_l3_counters(blk_num, true, false);

			if (err)

				return err;