Commit 0e32fdd7 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Keith Busch
Browse files

nvme-tcp: Fix a memory leak 



All error handling path end to the error handling path, except this one.
Go to the error handling branch as well here, otherwise 'icreq' and
'icresp' will leak.

Fixes: 2837966a ("nvme-tcp: control message handling for recvmsg()")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 744eac78

drivers/nvme/host/tcp.c

+2 −1
Original line number Diff line number Diff line
@@ -1423,13 +1423,14 @@ static int nvme_tcp_init_connection(struct nvme_tcp_queue *queue) 
			nvme_tcp_queue_id(queue), ret);

		goto free_icresp;

	}

	ret = -ENOTCONN;

	if (queue->ctrl->ctrl.opts->tls) {

		ctype = tls_get_record_type(queue->sock->sk,

					    (struct cmsghdr *)cbuf);

		if (ctype != TLS_RECORD_TYPE_DATA) {

			pr_err("queue %d: unhandled TLS record %d\n",

			       nvme_tcp_queue_id(queue), ctype);

			return -ENOTCONN;

			goto free_icresp;

		}

	}

	ret = -EINVAL;