Commit 0e39c9e5 authored by Dan Carpenter's avatar Dan Carpenter Committed by David Sterba
Browse files

btrfs: qgroup: fix initialization of auto inherit array



The "i++" was accidentally left out so it just sets qgids[0] over and
over.

This can lead to unexpected problems, as the groups[1:] would be all 0,
leading to later find_qgroup_rb() unable to find a qgroup and cause
snapshot creation failure.

Fixes: 5343cd93 ("btrfs: qgroup: simple quota auto hierarchy for nested subvolumes")
CC: stable@vger.kernel.org # 6.7+
Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent bc00965d
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -3123,7 +3123,7 @@ static int qgroup_auto_inherit(struct btrfs_fs_info *fs_info,
	qgids = res->qgroups;

	list_for_each_entry(qg_list, &inode_qg->groups, next_group)
		qgids[i] = qg_list->group->qgroupid;
		qgids[i++] = qg_list->group->qgroupid;

	*inherit = res;
	return 0;