Commit 0e4c1eb5 authored by Eric Biggers's avatar Eric Biggers Committed by Mikulas Patocka
Browse files

dm-verity-fec: warn even when there were no errors 



Currently FEC logs a warning message if at least one error was
corrected, or an error message if there were uncorrectable errors.
However, it doesn't log anything if there were no errors.

"No errors" is actually unexpected, though, considering that dm-verity
calls verity_fec_decode() only when a block's digest doesn't match.

If there were to ever be a bug where verity_fec_decode() is called on
blocks with the correct digest, then there would be no indication in the
log that FEC is running and degrading performance.

Therefore, let's log the warning message even when there were no errors.

Signed-off-by: default avatarEric Biggers <ebiggers@kernel.org>
Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
parent 23e6e57a

drivers/md/dm-verity-fec.c

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static int fec_decode_bufs(struct dm_verity *v, struct dm_verity_io *io, 
	if (r < 0 && neras)

		DMERR_LIMIT("%s: FEC %llu: failed to correct: %d",

			    v->data_dev->name, target_block, r);

	else if (r == 0 && corrected > 0)

	else if (r == 0)

		DMWARN_LIMIT("%s: FEC %llu: corrected %d errors",

			     v->data_dev->name, target_block, corrected);