Commit 0e629694 authored by Jakub Raczynski's avatar Jakub Raczynski Committed by David S. Miller
Browse files

net/mdiobus: Fix potential out-of-bounds read/write access 



When using publicly available tools like 'mdio-tools' to read/write data
from/to network interface and its PHY via mdiobus, there is no verification of
parameters passed to the ioctl and it accepts any mdio address.
Currently there is support for 32 addresses in kernel via PHY_MAX_ADDR define,
but it is possible to pass higher value than that via ioctl.
While read/write operation should generally fail in this case,
mdiobus provides stats array, where wrong address may allow out-of-bounds
read/write.

Fix that by adding address verification before read/write operation.
While this excludes this access from any statistics, it improves security of
read/write operation.

Fixes: 080bb352 ("net: phy: Maintain MDIO device and bus statistics")
Signed-off-by: default avatarJakub Raczynski <j.raczynski@samsung.com>
Reported-by: default avatarWenjing Shan <wenjing.shan@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d9816ec7

drivers/net/phy/mdio_bus.c

+6 −0
Original line number Diff line number Diff line
@@ -445,6 +445,9 @@ int __mdiobus_read(struct mii_bus *bus, int addr, u32 regnum) 


	lockdep_assert_held_once(&bus->mdio_lock);



	if (addr >= PHY_MAX_ADDR)

		return -ENXIO;



	if (bus->read)

		retval = bus->read(bus, addr, regnum);

	else
@@ -474,6 +477,9 @@ int __mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val) 


	lockdep_assert_held_once(&bus->mdio_lock);



	if (addr >= PHY_MAX_ADDR)

		return -ENXIO;



	if (bus->write)

		err = bus->write(bus, addr, regnum, val);

	else