Commit 0e71862a authored by Jiawen Wu's avatar Jiawen Wu Committed by Paolo Abeni
Browse files

net: txgbe: fix to clear interrupt status after handling IRQ 



GPIO EOI is not set to clear interrupt status after handling the
interrupt. It should be done in irq_chip->irq_ack, but this function
is not called in handle_nested_irq(). So executing function
txgbe_gpio_irq_ack() manually in txgbe_gpio_irq_handler().

Fixes: aefd0136 ("net: txgbe: use irq_domain for interrupt controller")
Signed-off-by: default avatarJiawen Wu <jiawenwu@trustnetic.com>
Link: https://lore.kernel.org/r/20240301092956.18544-2-jiawenwu@trustnetic.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent b4a2496c

drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c

+2 −0
Original line number Diff line number Diff line
@@ -475,8 +475,10 @@ irqreturn_t txgbe_gpio_irq_handler(int irq, void *data) 
	gc = txgbe->gpio;

	for_each_set_bit(hwirq, &gpioirq, gc->ngpio) {

		int gpio = irq_find_mapping(gc->irq.domain, hwirq);

		struct irq_data *d = irq_get_irq_data(gpio);

		u32 irq_type = irq_get_trigger_type(gpio);



		txgbe_gpio_irq_ack(d);

		handle_nested_irq(gpio);



		if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) {