Unverified Commit 0e7faea1 authored by Niklas Cassel's avatar Niklas Cassel Committed by Krzysztof Wilczyński
Browse files

PCI: endpoint: Verify that requested BAR size is a power of two 

When allocating a BAR using pci_epf_alloc_space(), there are checks that
round up the size to a power of two.

However, there is no check in pci_epc_set_bar() which verifies that the
requested BAR size is a power of two.

Add a power of two check in pci_epc_set_bar(), so that we don't need to
add such a check in each and every PCI endpoint controller driver.

Link: https://lore.kernel.org/r/20241213143301.4158431-14-cassel@kernel.org


Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent f015b53d

drivers/pci/endpoint/pci-epc-core.c

+3 −0
Original line number Diff line number Diff line
@@ -613,6 +613,9 @@ int pci_epc_set_bar(struct pci_epc *epc, u8 func_no, u8 vfunc_no, 
	    (epc_features->bar[bar].fixed_size != epf_bar->size))

		return -EINVAL;



	if (!is_power_of_2(epf_bar->size))

		return -EINVAL;



	if ((epf_bar->barno == BAR_5 && flags & PCI_BASE_ADDRESS_MEM_TYPE_64) ||

	    (flags & PCI_BASE_ADDRESS_SPACE_IO &&

	     flags & PCI_BASE_ADDRESS_IO_MASK) ||