Commit 0e805e8b authored by Nai-Chen Cheng's avatar Nai-Chen Cheng Committed by Greg Kroah-Hartman
Browse files

greybus: svc: use string choice helpers instead of ternary operator 



Replace ternary operator with str_enabled_disabled() helper to improve
code readability and consistency.

Generated using Coccinelle semantic patch.

Signed-off-by: default avatarNai-Chen Cheng <bleach1827@gmail.com>
Reviewed-by: default avatarAlex Elder <elder@riscstar.com>
Link: https://lore.kernel.org/r/20250806-greybus-string-choices-v1-1-3e1c91048b62@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 51ad6d97

drivers/greybus/svc.c

+2 −1
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ 
#include <linux/kstrtox.h>

#include <linux/workqueue.h>

#include <linux/greybus.h>

#include <linux/string_choices.h>



#define SVC_INTF_EJECT_TIMEOUT		9000

#define SVC_INTF_ACTIVATE_TIMEOUT	6000
@@ -73,7 +74,7 @@ static ssize_t watchdog_show(struct device *dev, struct device_attribute *attr, 
	struct gb_svc *svc = to_gb_svc(dev);



	return sprintf(buf, "%s\n",

		       gb_svc_watchdog_enabled(svc) ? "enabled" : "disabled");

		       str_enabled_disabled(gb_svc_watchdog_enabled(svc)));

}



static ssize_t watchdog_store(struct device *dev,