Commit 0e9a2990 authored by Damien Le Moal's avatar Damien Le Moal
Browse files

ata: libata-scsi: Fix ata_msense_control() CDL page reporting 



When the user requests the ALL_SUB_MPAGES mode sense page,
ata_msense_control() adds the CDL_T2A_SUB_MPAGE twice instead of adding
the CDL_T2A_SUB_MPAGE and CDL_T2B_SUB_MPAGE pages information. Correct
the second call to ata_msense_control_spgt2() to report the
CDL_T2B_SUB_MPAGE page.

Fixes: 673b2fe6 ("scsi: ata: libata-scsi: Add support for CDL pages mode sense")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
parent 03a9cfc1

drivers/ata/libata-scsi.c

+1 −1
Original line number Diff line number Diff line
@@ -2350,7 +2350,7 @@ static unsigned int ata_msense_control(struct ata_device *dev, u8 *buf, 
	case ALL_SUB_MPAGES:

		n = ata_msense_control_spg0(dev, buf, changeable);

		n += ata_msense_control_spgt2(dev, buf + n, CDL_T2A_SUB_MPAGE);

		n += ata_msense_control_spgt2(dev, buf + n, CDL_T2A_SUB_MPAGE);

		n += ata_msense_control_spgt2(dev, buf + n, CDL_T2B_SUB_MPAGE);

		n += ata_msense_control_ata_feature(dev, buf + n);

		return n;

	default: