Unverified Commit 0ebbd45c authored by Haotian Zhang's avatar Haotian Zhang Committed by Mark Brown
Browse files

ASoC: bcm: bcm63xx-pcm-whistler: Check return value of of_dma_configure() 



bcm63xx_soc_pcm_new() does not check the return value of
of_dma_configure(), which may fail with -EPROBE_DEFER or
other errors, allowing PCM setup to continue with incomplete
DMA configuration.

Add error checking for of_dma_configure() and return on failure.

Fixes: 88eb404c ("ASoC: brcm: Add DSL/PON SoC audio driver")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251202101642.492-1-vulab@iscas.ac.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2b69bee5

sound/soc/bcm/bcm63xx-pcm-whistler.c

+3 −1
Original line number Diff line number Diff line
@@ -358,7 +358,9 @@ static int bcm63xx_soc_pcm_new(struct snd_soc_component *component, 


	i2s_priv = dev_get_drvdata(snd_soc_rtd_to_cpu(rtd, 0)->dev);



	of_dma_configure(pcm->card->dev, pcm->card->dev->of_node, 1);

	ret = of_dma_configure(pcm->card->dev, pcm->card->dev->of_node, 1);

	if (ret)

		return ret;



	ret = dma_coerce_mask_and_coherent(pcm->card->dev, DMA_BIT_MASK(32));

	if (ret)