Commit 0ee30d93 authored by Matteo Croce's avatar Matteo Croce Committed by Andrii Nakryiko
Browse files

libbpf: Fix warning in calloc() usage 



When compiling libbpf with some compilers, this warning is triggered:

libbpf.c: In function ‘bpf_object__gen_loader’:
libbpf.c:9209:28: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
 9209 |         gen = calloc(sizeof(*gen), 1);
      |                            ^
libbpf.c:9209:28: note: earlier argument should specify number of elements, later size of each element

Fix this by inverting the calloc() arguments.

Signed-off-by: default avatarMatteo Croce <teknoraver@meta.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Acked-by: default avatarYonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/bpf/20250717200337.49168-1-technoboy85@gmail.com
parent 0768e980

tools/lib/bpf/libbpf.c

+1 −1
Original line number Diff line number Diff line
@@ -9210,7 +9210,7 @@ int bpf_object__gen_loader(struct bpf_object *obj, struct gen_loader_opts *opts) 
		return libbpf_err(-EFAULT);

	if (!OPTS_VALID(opts, gen_loader_opts))

		return libbpf_err(-EINVAL);

	gen = calloc(sizeof(*gen), 1);

	gen = calloc(1, sizeof(*gen));

	if (!gen)

		return libbpf_err(-ENOMEM);

	gen->opts = opts;