Commit 0ef2a9b2 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Krzysztof Kozlowski
Browse files

w1: ds2805: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241211-sysfs-const-bin_attr-w1-v1-11-c4befd2aa7cc@weissschuh.net


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent c797bbda

drivers/w1/slaves/w1_ds2805.c

+5 −5
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ static int w1_f0d_readblock(struct w1_slave *sl, int off, int count, char *buf) 
}



static ssize_t w1_f0d_read_bin(struct file *filp, struct kobject *kobj,

			       struct bin_attribute *bin_attr,

			       const struct bin_attribute *bin_attr,

			       char *buf, loff_t off, size_t count)

{

	struct w1_slave *sl = kobj_to_w1_slave(kobj);
@@ -200,7 +200,7 @@ static int w1_f0d_write(struct w1_slave *sl, int addr, int len, const u8 *data) 
}



static ssize_t w1_f0d_write_bin(struct file *filp, struct kobject *kobj,

				struct bin_attribute *bin_attr,

				const struct bin_attribute *bin_attr,

				char *buf, loff_t off, size_t count)

{

	struct w1_slave *sl = kobj_to_w1_slave(kobj);
@@ -261,14 +261,14 @@ static ssize_t w1_f0d_write_bin(struct file *filp, struct kobject *kobj, 
	return count;

}



static struct bin_attribute w1_f0d_bin_attr = {

static const struct bin_attribute w1_f0d_bin_attr = {

	.attr = {

		.name = "eeprom",

		.mode = 0644,

	},

	.size = W1_F0D_EEPROM_SIZE,

	.read = w1_f0d_read_bin,

	.write = w1_f0d_write_bin,

	.read_new = w1_f0d_read_bin,

	.write_new = w1_f0d_write_bin,

};



static int w1_f0d_add_slave(struct w1_slave *sl)