Commit 0ef9ab34 authored by Alan Huang's avatar Alan Huang Committed by Kent Overstreet
Browse files

bcachefs: Do not allow no fail lock request to fail 



If the transaction chose itself as a victim before and restarted, it
might request a no fail lock request this time. But it might be added to
others' lock graph and be chose as the victim again, it's no longer safe
without additional check. We can also convert the cycle detector to be
fully RCU-based to solve that unsoundness, but the latency added to trans_put
and additional memory required may not worth it.

Signed-off-by: default avatarAlan Huang <mmpgouride@gmail.com>
Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent cdc419db

fs/bcachefs/btree_locking.c

+1 −1
Original line number Diff line number Diff line
@@ -281,7 +281,7 @@ int bch2_check_for_deadlock(struct btree_trans *trans, struct printbuf *cycle) 


	g.nr = 0;



	if (trans->lock_must_abort) {

	if (trans->lock_must_abort && !trans->lock_may_not_fail) {

		if (cycle)

			return -1;