Commit 0f0c3329 authored by Jiri Olsa's avatar Jiri Olsa Committed by Alexei Starovoitov
Browse files

bpf: Allow sleepable programs to use tail calls 



Allowing sleepable programs to use tail calls.

Making sure we can't mix sleepable and non-sleepable bpf programs
in tail call map (BPF_MAP_TYPE_PROG_ARRAY) and allowing it to be
used in sleepable programs.

Sleepable programs can be preempted and sleep which might bring
new source of race conditions, but both direct and indirect tail
calls should not be affected.

Direct tail calls work by patching direct jump to callee into bpf
caller program, so no problem there. We atomically switch from nop
to jump instruction.

Indirect tail call reads the callee from the map and then jumps to
it. The callee bpf program can't disappear (be released) from the
caller, because it is executed under rcu lock (rcu_read_lock_trace).

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Acked-by: default avatarLeon Hwang <leon.hwang@linux.dev>
Link: https://lore.kernel.org/r/20260130081208.1130204-2-jolsa@kernel.org


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 95dbe214

include/linux/bpf.h

+1 −0
Original line number Diff line number Diff line
@@ -287,6 +287,7 @@ struct bpf_map_owner { 
	enum bpf_prog_type type;

	bool jited;

	bool xdp_has_frags;

	bool sleepable;

	u64 storage_cookie[MAX_BPF_CGROUP_STORAGE_TYPE];

	const struct btf_type *attach_func_proto;

	enum bpf_attach_type expected_attach_type;

kernel/bpf/core.c

+3 −1
Original line number Diff line number Diff line
@@ -2401,6 +2401,7 @@ static bool __bpf_prog_map_compatible(struct bpf_map *map, 
		map->owner->type  = prog_type;

		map->owner->jited = fp->jited;

		map->owner->xdp_has_frags = aux->xdp_has_frags;

		map->owner->sleepable = fp->sleepable;

		map->owner->expected_attach_type = fp->expected_attach_type;

		map->owner->attach_func_proto = aux->attach_func_proto;

		for_each_cgroup_storage_type(i) {
@@ -2412,7 +2413,8 @@ static bool __bpf_prog_map_compatible(struct bpf_map *map, 
	} else {

		ret = map->owner->type  == prog_type &&

		      map->owner->jited == fp->jited &&

		      map->owner->xdp_has_frags == aux->xdp_has_frags;

		      map->owner->xdp_has_frags == aux->xdp_has_frags &&

		      map->owner->sleepable == fp->sleepable;

		if (ret &&

		    map->map_type == BPF_MAP_TYPE_PROG_ARRAY &&

		    map->owner->expected_attach_type != fp->expected_attach_type)

kernel/bpf/verifier.c

+1 −0
Original line number Diff line number Diff line
@@ -21386,6 +21386,7 @@ static int check_map_prog_compatibility(struct bpf_verifier_env *env, 
		case BPF_MAP_TYPE_STACK:

		case BPF_MAP_TYPE_ARENA:

		case BPF_MAP_TYPE_INSN_ARRAY:

		case BPF_MAP_TYPE_PROG_ARRAY:

			break;

		default:

			verbose(env,