Commit 0f2c8e27 authored by Joel Fernandes's avatar Joel Fernandes Committed by Alexandre Courbot
Browse files

gpu: nova-core: falcon: Move dma_reset functionality into helper 



Move dma_reset so we can use it for the upcoming sequencer
functionality.

Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Signed-off-by: default avatarJoel Fernandes <joelagnelf@nvidia.com>
Signed-off-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251114195552.739371-5-joelagnelf@nvidia.com>
parent 4f7656f7

drivers/gpu/nova-core/falcon.rs

+7 −2
Original line number Diff line number Diff line
@@ -382,6 +382,12 @@ pub(crate) fn new(dev: &device::Device, chipset: Chipset) -> Result<Self> { 
        })

    }



    /// Resets DMA-related registers.

    pub(crate) fn dma_reset(&self, bar: &Bar0) {

        regs::NV_PFALCON_FBIF_CTL::update(bar, &E::ID, |v| v.set_allow_phys_no_ctx(true));

        regs::NV_PFALCON_FALCON_DMACTL::default().write(bar, &E::ID);

    }



    /// Wait for memory scrubbing to complete.

    fn reset_wait_mem_scrubbing(&self, bar: &Bar0) -> Result {

        // TIMEOUT: memory scrubbing should complete in less than 20ms.
@@ -531,8 +537,7 @@ fn dma_wr<F: FalconFirmware<Target = E>>( 


    /// Perform a DMA load into `IMEM` and `DMEM` of `fw`, and prepare the falcon to run it.

    pub(crate) fn dma_load<F: FalconFirmware<Target = E>>(&self, bar: &Bar0, fw: &F) -> Result {

        regs::NV_PFALCON_FBIF_CTL::update(bar, &E::ID, |v| v.set_allow_phys_no_ctx(true));

        regs::NV_PFALCON_FALCON_DMACTL::default().write(bar, &E::ID);

        self.dma_reset(bar);

        regs::NV_PFALCON_FBIF_TRANSCFG::update(bar, &E::ID, 0, |v| {

            v.set_target(FalconFbifTarget::CoherentSysmem)

                .set_mem_type(FalconFbifMemType::Physical)