Commit 0f31c091 authored by Colin Ian King's avatar Colin Ian King Committed by Vinod Koul
Browse files

dmaengine: xilinx: xdma: remove redundant check on ret 



The variable ret is being checked for an error and returning ret
and the following statement returns ret too. The if check is
redundant, and remove it. Just return the value returned from
the call to regmap_write.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20241107114656.17611-1-colin.i.king@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent bf9b0834

drivers/dma/xilinx/xdma.c

+2 −6
Original line number Diff line number Diff line
@@ -390,15 +390,11 @@ static int xdma_xfer_start(struct xdma_chan *xchan) 
 */

static int xdma_xfer_stop(struct xdma_chan *xchan)

{

	int ret;

	struct xdma_device *xdev = xchan->xdev_hdl;



	/* clear run stop bit to prevent any further auto-triggering */

	ret = regmap_write(xdev->rmap, xchan->base + XDMA_CHAN_CONTROL_W1C,

	return regmap_write(xdev->rmap, xchan->base + XDMA_CHAN_CONTROL_W1C,

			    CHAN_CTRL_RUN_STOP);

	if (ret)

		return ret;

	return ret;

}



/**