Commit 0f3c0a19 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: nl80211: fix NL80211_PMSR_FTM_REQ_ATTR_FTMS_PER_BURST usage 

This is documented as a u8 and has a policy of NLA_U8, but uses
nla_get_u32() which means it's completely broken on big-endian.
Fix it to use nla_get_u8().

Fixes: 9bb7e0f2 ("cfg80211: add peer measurement with FTM initiator API")
Link: https://patch.msgid.link/20260505113837.260159-2-johannes@sipsolutions.net


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 283fc9e4

net/wireless/pmsr.c

+1 −1
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ static int pmsr_parse_ftm(struct cfg80211_registered_device *rdev, 
	out->ftm.ftms_per_burst = 0;

	if (tb[NL80211_PMSR_FTM_REQ_ATTR_FTMS_PER_BURST])

		out->ftm.ftms_per_burst =

			nla_get_u32(tb[NL80211_PMSR_FTM_REQ_ATTR_FTMS_PER_BURST]);

			nla_get_u8(tb[NL80211_PMSR_FTM_REQ_ATTR_FTMS_PER_BURST]);



	if (capa->ftm.max_ftms_per_burst &&

	    (out->ftm.ftms_per_burst > capa->ftm.max_ftms_per_burst ||