Commit 0f5aa1b0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

usb: usbtest: fix a type promotion bug 



The "len" here is sometimes negative error codes from
usb_get_descriptor(), so we don't want to type promote them to unsigned
long.

This bug pre-dates the invention of git.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/506f7935-2cba-41d9-ab5d-ddb6ad6320bd@moroto.mountain


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b8aaf639

drivers/usb/misc/usbtest.c

+1 −1
Original line number Diff line number Diff line
@@ -705,7 +705,7 @@ static int is_good_config(struct usbtest_dev *tdev, int len) 
{

	struct usb_config_descriptor	*config;



	if (len < sizeof(*config))

	if (len < (int)sizeof(*config))

		return 0;

	config = (struct usb_config_descriptor *) tdev->buf;