Commit 0f6f0d68 authored Nov 07, 2024 by Ira Weiny Committed by Dave Jiang Nov 08, 2024

cxl/pci: Delay event buffer allocation



The event buffer does not need to be allocated if something has failed in
setting up event irq's.

In prep for adjusting event configuration for DCD events move the buffer
allocation to the end of the event configuration.

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Li Ming <ming4.li@intel.com>
Link: https://lore.kernel.org/all/663922b475e50_d54d72945b@dwillia2-xfh.jf.intel.com.notmuch/

 [1]
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/20241107-dcd-type2-upstream-v7-4-56a84e66bc36@intel.com


Signed-off-by: Dave Jiang <dave.jiang@intel.com>

parent f88b3ecc

drivers/cxl/pci.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -764,10 +764,6 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
		return 0;
		}

		rc = cxl_mem_alloc_event_buf(mds);
		if (rc)
		return rc;

		rc = cxl_event_get_int_policy(mds, &policy);
		if (rc)
		return rc;
		@@ -781,6 +777,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
		return -EBUSY;
		}

		rc = cxl_mem_alloc_event_buf(mds);
		if (rc)
		return rc;

		rc = cxl_event_irqsetup(mds);
		if (rc)
		return rc;