Unverified Commit 0f997fda authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

spi: mpc52xx: fix controller deregistration 



Make sure to deregister the controller before disabling and releasing
underlying resources like interrupts and gpios during driver unbind.

Fixes: 42bbb709 ("powerpc/5200: Add mpc5200-spi (non-PSC) device driver")
Fixes: b8d4e2ce ("mpc52xx_spi: add gpio chipselect")
Cc: stable@vger.kernel.org	# 2.6.33
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260414134319.978196-4-johan@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 964ee979

drivers/spi/spi-mpc52xx.c

+2 −1
Original line number Diff line number Diff line
@@ -517,6 +517,8 @@ static void mpc52xx_spi_remove(struct platform_device *op) 
	struct mpc52xx_spi *ms = spi_controller_get_devdata(host);

	int i;



	spi_unregister_controller(host);



	cancel_work_sync(&ms->work);

	free_irq(ms->irq0, ms);

	free_irq(ms->irq1, ms);
@@ -525,7 +527,6 @@ static void mpc52xx_spi_remove(struct platform_device *op) 
		gpiod_put(ms->gpio_cs[i]);



	kfree(ms->gpio_cs);

	spi_unregister_controller(host);

	iounmap(ms->regs);

	spi_controller_put(host);

}