Unverified Commit 0f9bfb84 authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Mark Brown
Browse files

ASoC: cs35l56: Fix out-of-bounds in dev_err() in cs35l56_read_onchip_spkid() 



Remove the incorrect use of onchip_spkid_gpios[i] in the dev_err() after
regmap_read() of CS35L56_GPIO_STATUS1 returns an error.

This dev_err() was incorrectly copy-pasted from one inside the for-loop,
where i was valid. The read of CS35L56_GPIO_STATUS1 isn't for a specific
GPIO register, so the use of onchip_spkid_gpios[i] in the error message is
both irrelevant and out-of-bounds here.

Fixes: 4d1e3e2c ("ASoC: cs35l56: Support for reading speaker ID from on-chip GPIOs")
Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20260430101134.2655938-1-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0e60d966

sound/soc/codecs/cs35l56-shared.c

+1 −2
Original line number Diff line number Diff line
@@ -1730,8 +1730,7 @@ int cs35l56_read_onchip_spkid(struct cs35l56_base *cs35l56_base) 


	ret = regmap_read(regmap, CS35L56_GPIO_STATUS1, &val);

	if (ret) {

		dev_err(cs35l56_base->dev, "GPIO%d status read failed: %d\n",

			cs35l56_base->onchip_spkid_gpios[i] + 1, ret);

		dev_err(cs35l56_base->dev, "GPIO status read failed: %d\n", ret);

		return ret;

	}