Commit 0fccfb63 authored by Matthew Brost's avatar Matthew Brost
Browse files

drm/xe: Use WRITE_ONCE for range->tile_invalidated update 



Updating range->tile_invalidated should be done with WRITE_ONCE to pair
with READ_ONCE in opportunistic checks.

Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMaarten Lankhrost <maarten.lankhorst@linux.intel.com>
Link: https://lore.kernel.org/r/20250604234712.2441130-1-matthew.brost@intel.com
parent 265fa069

drivers/gpu/drm/xe/xe_svm.c

+5 −2
Original line number Diff line number Diff line
@@ -141,7 +141,9 @@ xe_svm_range_notifier_event_begin(struct xe_vm *vm, struct drm_gpusvm_range *r, 
	for_each_tile(tile, xe, id)

		if (xe_pt_zap_ptes_range(tile, vm, range)) {

			tile_mask |= BIT(id);

			range->tile_invalidated |= BIT(id);

			/* Pairs with READ_ONCE in xe_svm_range_is_valid */

			WRITE_ONCE(range->tile_invalidated,

				   range->tile_invalidated | BIT(id));

		}



	return tile_mask;
@@ -644,7 +646,8 @@ static bool xe_svm_range_is_valid(struct xe_svm_range *range, 
{

	/*

	 * Advisory only check whether the range currently has a valid mapping,

	 * READ_ONCE pairs with WRITE_ONCE in xe_pt.c

	 * READ_ONCE pairs with WRITE_ONCE in xe_pt.c,

	 * xe_svm_range_notifier_event_begin

	 */

	return ((READ_ONCE(range->tile_present) &

		 ~READ_ONCE(range->tile_invalidated)) & BIT(tile->id)) &&