Commit 0fe23476 authored by Paul Blakey's avatar Paul Blakey Committed by Jakub Kicinski
Browse files

net/mlx5e: CT: Filter legacy rules that are unrelated to nic 



In nic mode CT setup where we do hairpin between the two
nics, both nics register to the same flow table (per zone),
and try to offload all rules on it.

Instead, filter the rules that originated from the relevant nic
(so only one side is offloaded for each nic).

Signed-off-by: default avatarPaul Blakey <paulb@nvidia.com>
Reviewed-by: default avatarJianbo Liu <jianbol@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/1742392983-153050-5-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 91e7398e

drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c

+29 −0
Original line number Diff line number Diff line
@@ -1349,6 +1349,32 @@ mlx5_tc_ct_block_flow_offload_stats(struct mlx5_ct_ft *ft, 
	return 0;

}



static bool

mlx5_tc_ct_filter_legacy_non_nic_flows(struct mlx5_ct_ft *ft,

				       struct flow_cls_offload *flow)

{

	struct flow_rule *rule = flow_cls_offload_flow_rule(flow);

	struct mlx5_tc_ct_priv *ct_priv = ft->ct_priv;

	struct flow_match_meta match;

	struct net_device *netdev;

	bool same_dev = false;



	if (!is_mdev_legacy_mode(ct_priv->dev) ||

	    !flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_META))

		return true;



	flow_rule_match_meta(rule, &match);



	if (!(match.key->ingress_ifindex & match.mask->ingress_ifindex))

		return true;



	netdev = dev_get_by_index(&init_net, match.key->ingress_ifindex);

	same_dev = ct_priv->netdev == netdev;

	dev_put(netdev);



	return same_dev;

}



static int

mlx5_tc_ct_block_flow_offload(enum tc_setup_type type, void *type_data,

			      void *cb_priv)
@@ -1361,6 +1387,9 @@ mlx5_tc_ct_block_flow_offload(enum tc_setup_type type, void *type_data, 


	switch (f->command) {

	case FLOW_CLS_REPLACE:

		if (!mlx5_tc_ct_filter_legacy_non_nic_flows(ft, f))

			return -EOPNOTSUPP;



		return mlx5_tc_ct_block_flow_offload_add(ft, f);

	case FLOW_CLS_DESTROY:

		return mlx5_tc_ct_block_flow_offload_del(ft, f);