Commit 0fe29838 authored by David Sterba's avatar David Sterba
Browse files

btrfs: handle root deletion lookup error in btrfs_del_root() 



We're deleting a root and looking it up by key does not succeed, this
is an inconsistent state and we can't do anything. All callers handle
errors and abort a transaction.

Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarAnand Jain <anand.jain@oracle.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 97ec3320

fs/btrfs/root-tree.c

+5 −2
Original line number Diff line number Diff line
@@ -322,8 +322,11 @@ int btrfs_del_root(struct btrfs_trans_handle *trans, 
	ret = btrfs_search_slot(trans, root, key, path, -1, 1);

	if (ret < 0)

		goto out;



	BUG_ON(ret != 0);

	if (ret != 0) {

		/* The root must exist but we did not find it by the key. */

		ret = -EUCLEAN;

		goto out;

	}



	ret = btrfs_del_item(trans, root, path);

out: