Commit 0ffba246 authored by Kohei Enju's avatar Kohei Enju Committed by Tony Nguyen
Browse files

igc: fix missing update of skb->tail in igc_xmit_frame() 



igc_xmit_frame() misses updating skb->tail when the packet size is
shorter than the minimum one.
Use skb_put_padto() in alignment with other Intel Ethernet drivers.

Fixes: 0507ef8a ("igc: Add transmit and receive fastpath and interrupt handlers")
Signed-off-by: default avatarKohei Enju <kohei@enjuk.jp>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarPaul Menzel <pmenzel@molgen.mpg.de>
Tested-by: default avatarAvigail Dahan <avigailx.dahan@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 069c8f5a

drivers/net/ethernet/intel/igc/igc_main.c

+2 −5
Original line number Diff line number Diff line
@@ -1730,11 +1730,8 @@ static netdev_tx_t igc_xmit_frame(struct sk_buff *skb, 
	/* The minimum packet size with TCTL.PSP set is 17 so pad the skb

	 * in order to meet this minimum size requirement.

	 */

	if (skb->len < 17) {

		if (skb_padto(skb, 17))

	if (skb_put_padto(skb, 17))

		return NETDEV_TX_OK;

		skb->len = 17;

	}



	return igc_xmit_frame_ring(skb, igc_tx_queue_mapping(adapter, skb));

}