Commit 1004c346 authored by Yang Yingliang's avatar Yang Yingliang Committed by Stephen Boyd
Browse files

clk: sp7021: fix return value check in sp7021_clk_probe() 



devm_platform_ioremap_resource() never returns NULL pointer,
it will return ERR_PTR() when it fails, so replace the check
with IS_ERR().

Fixes: d54c1fd4 ("clk: Add Sunplus SP7021 clock driver")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20231128133016.2494699-1-yangyingliang@huawei.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent b85ea95d

drivers/clk/clk-sp7021.c

+6 −6
Original line number Diff line number Diff line
@@ -604,14 +604,14 @@ static int sp7021_clk_probe(struct platform_device *pdev) 
	int i;



	clk_base = devm_platform_ioremap_resource(pdev, 0);

	if (!clk_base)

		return -ENXIO;

	if (IS_ERR(clk_base))

		return PTR_ERR(clk_base);

	pll_base = devm_platform_ioremap_resource(pdev, 1);

	if (!pll_base)

		return -ENXIO;

	if (IS_ERR(pll_base))

		return PTR_ERR(pll_base);

	sys_base = devm_platform_ioremap_resource(pdev, 2);

	if (!sys_base)

		return -ENXIO;

	if (IS_ERR(sys_base))

		return PTR_ERR(sys_base);



	/* enable default clks */

	for (i = 0; i < ARRAY_SIZE(sp_clken); i++)