Commit 10343e7e authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

inet: ping: remove ping_hash() 



There is no point in keeping ping_hash().

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Reviewed-by: default avatarYue Haibing <yuehaibing@huawei.com>
Link: https://patch.msgid.link/20250829153054.474201-3-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 59f26d86

include/net/ping.h

+0 −1
Original line number Diff line number Diff line
@@ -54,7 +54,6 @@ struct pingfakehdr { 
};



int  ping_get_port(struct sock *sk, unsigned short ident);

int ping_hash(struct sock *sk);

void ping_unhash(struct sock *sk);



int  ping_init_sock(struct sock *sk);

net/ipv4/ping.c

+0 −10
Original line number Diff line number Diff line
@@ -67,7 +67,6 @@ static inline u32 ping_hashfn(const struct net *net, u32 num, u32 mask) 
	pr_debug("hash(%u) = %u\n", num, res);

	return res;

}

EXPORT_SYMBOL_GPL(ping_hash);



static inline struct hlist_head *ping_hashslot(struct ping_table *table,

					       struct net *net, unsigned int num)
@@ -144,14 +143,6 @@ int ping_get_port(struct sock *sk, unsigned short ident) 
}

EXPORT_SYMBOL_GPL(ping_get_port);



int ping_hash(struct sock *sk)

{

	pr_debug("ping_hash(sk->port=%u)\n", inet_sk(sk)->inet_num);

	BUG(); /* "Please do not press this button again." */



	return 0;

}



void ping_unhash(struct sock *sk)

{

	struct inet_sock *isk = inet_sk(sk);
@@ -1008,7 +999,6 @@ struct proto ping_prot = { 
	.bind =		ping_bind,

	.backlog_rcv =	ping_queue_rcv_skb,

	.release_cb =	ip4_datagram_release_cb,

	.hash =		ping_hash,

	.unhash =	ping_unhash,

	.get_port =	ping_get_port,

	.put_port =	ping_unhash,

net/ipv6/ping.c

+0 −1
Original line number Diff line number Diff line
@@ -208,7 +208,6 @@ struct proto pingv6_prot = { 
	.recvmsg =	ping_recvmsg,

	.bind =		ping_bind,

	.backlog_rcv =	ping_queue_rcv_skb,

	.hash =		ping_hash,

	.unhash =	ping_unhash,

	.get_port =	ping_get_port,

	.put_port =	ping_unhash,