Commit 10416a35 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Takashi Sakamoto
Browse files

firewire: make fw_bus_type const 



Now that the driver core can properly handle constant struct bus_type,
move the fw_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: linux1394-devel@lists.sourceforge.net
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/2023121931-skydiver-dodgy-d1bd@gregkh


Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
parent 0dd3ee31

drivers/firewire/core-device.c

+1 −1
Original line number Diff line number Diff line
@@ -219,7 +219,7 @@ static int fw_unit_uevent(const struct device *dev, struct kobj_uevent_env *env) 
	return 0;

}



struct bus_type fw_bus_type = {

const struct bus_type fw_bus_type = {

	.name = "firewire",

	.match = fw_unit_match,

	.probe = fw_unit_probe,

include/linux/firewire.h

+1 −1
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ void fw_csr_iterator_init(struct fw_csr_iterator *ci, const u32 *p); 
int fw_csr_iterator_next(struct fw_csr_iterator *ci, int *key, int *value);

int fw_csr_string(const u32 *directory, int key, char *buf, size_t size);



extern struct bus_type fw_bus_type;

extern const struct bus_type fw_bus_type;



struct fw_card_driver;

struct fw_node;