Commit 106133da authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

usb: gadget: s3c-hsudc: Use struct_size() in devm_kzalloc() 



Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows
that, in the worse scenario, could lead to heap overflows.

This code was detected with the help of Coccinelle and, audited and
fixed manually.

Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20210513193353.GA196565@embeddedor


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 53ad92fd

drivers/usb/gadget/udc/s3c-hsudc.c

+2 −3
Original line number Diff line number Diff line
@@ -1220,8 +1220,7 @@ static int s3c_hsudc_probe(struct platform_device *pdev) 
	struct s3c24xx_hsudc_platdata *pd = dev_get_platdata(&pdev->dev);

	int ret, i;



	hsudc = devm_kzalloc(&pdev->dev, sizeof(struct s3c_hsudc) +

			sizeof(struct s3c_hsudc_ep) * pd->epnum,

	hsudc = devm_kzalloc(&pdev->dev, struct_size(hsudc, ep, pd->epnum),

			     GFP_KERNEL);

	if (!hsudc)

		return -ENOMEM;