Commit 108d8aec authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

ublk: avoid redundant io->cmd in ublk_queue_cmd_list() 



ublk_queue_cmd_list() loads io->cmd twice. The intervening stores
prevent the compiler from combining the loads. Since struct ublk_io *io
is only used to compute io->cmd, replace the variable with io->cmd.

Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Link: https://lore.kernel.org/r/20250328180411.2696494-5-csander@purestorage.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 6a87fc43

drivers/block/ublk_drv.c

+3 −3
Original line number Diff line number Diff line
@@ -1301,12 +1301,12 @@ static void ublk_cmd_list_tw_cb(struct io_uring_cmd *cmd, 
static void ublk_queue_cmd_list(struct ublk_queue *ubq, struct rq_list *l)

{

	struct request *rq = rq_list_peek(l);

	struct ublk_io *io = &ubq->ios[rq->tag];

	struct ublk_uring_cmd_pdu *pdu = ublk_get_uring_cmd_pdu(io->cmd);

	struct io_uring_cmd *cmd = ubq->ios[rq->tag].cmd;

	struct ublk_uring_cmd_pdu *pdu = ublk_get_uring_cmd_pdu(cmd);



	pdu->req_list = rq;

	rq_list_init(l);

	io_uring_cmd_complete_in_task(io->cmd, ublk_cmd_list_tw_cb);

	io_uring_cmd_complete_in_task(cmd, ublk_cmd_list_tw_cb);

}



static enum blk_eh_timer_return ublk_timeout(struct request *rq)