Commit 109ff654 authored by Dharma Balasubiramani's avatar Dharma Balasubiramani Committed by William Breathitt Gray
Browse files

counter: microchip-tcb-capture: Allow shared IRQ for multi-channel TCBs 



Mark the interrupt as IRQF_SHARED to permit multiple counter channels to
share the same TCB IRQ line.

Each Timer/Counter Block (TCB) instance shares a single IRQ line among its
three internal channels. When multiple counter channels (e.g., counter@0
and counter@1) within the same TCB are enabled, the second call to
devm_request_irq() fails because the IRQ line is already requested by the
first channel.

Cc: stable@vger.kernel.org
Fixes: e5d58139 ("counter: microchip-tcb-capture: Add IRQ handling")
Signed-off-by: default avatarDharma Balasubiramani <dharma.b@microchip.com>
Reviewed-by: default avatarKamel Bouhara <kamel.bouhara@bootlin.com>
Reviewed-by: default avatarBence Csókás <bence98@sch.bme.hu>
Link: https://lore.kernel.org/r/20251006-microchip-tcb-v1-1-09c19181bb4a@microchip.com


Signed-off-by: default avatarWilliam Breathitt Gray <wbg@kernel.org>
parent 3a866087

drivers/counter/microchip-tcb-capture.c

+1 −1
Original line number Diff line number Diff line
@@ -451,7 +451,7 @@ static void mchp_tc_irq_remove(void *ptr) 
static int mchp_tc_irq_enable(struct counter_device *const counter, int irq)

{

	struct mchp_tc_data *const priv = counter_priv(counter);

	int ret = devm_request_irq(counter->parent, irq, mchp_tc_isr, 0,

	int ret = devm_request_irq(counter->parent, irq, mchp_tc_isr, IRQF_SHARED,

				   dev_name(counter->parent), counter);



	if (ret < 0)