Commit 10a77965 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Jakub Kicinski
Browse files

batman-adv: Fix double-hold of meshif when getting enabled 



It was originally meant to replace the dev_hold with netdev_hold. But this
was missed in batadv_hardif_enable_interface(). As result, there was an
imbalance and a hang when trying to remove the mesh-interface with
(previously) active hard-interfaces:

  unregister_netdevice: waiting for batadv0 to become free. Usage count = 3

Fixes: 00b35530 ("batman-adv: adopt netdev_hold() / netdev_put()")
Suggested-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatar <syzbot+ff3aa851d46ab82953a3@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+4036165fc595a74b09b2@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+c35d73ce910d86c0026e@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+48c14f61594bdfadb086@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+f37372d86207b3bb2941@syzkaller.appspotmail.com>
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250414-double_hold_fix-v5-1-10e056324cde@narfation.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 277cc13a

net/batman-adv/hard-interface.c

+0 −1
Original line number Diff line number Diff line
@@ -725,7 +725,6 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface, 


	kref_get(&hard_iface->refcount);



	dev_hold(mesh_iface);

	netdev_hold(mesh_iface, &hard_iface->meshif_dev_tracker, GFP_ATOMIC);

	hard_iface->mesh_iface = mesh_iface;

	bat_priv = netdev_priv(hard_iface->mesh_iface);