Commit 10d32b0d authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

tools: ynl: use 'cond is None' 

It is better to use the 'is' keyword instead of comparing to None
according to Ruff.

This is linked to Ruff error E711 [1]:

  According to PEP 8, "Comparisons to singletons like None should always
  be done with is or is not, never the equality operators."

Link: https://docs.astral.sh/ruff/rules/none-comparison/

 [1]
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Reviewed-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Link: https://patch.msgid.link/20250909-net-next-ynl-ruff-v1-7-238c2bccdd99@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 616129d6

tools/net/ynl/pyynl/lib/ynl.py

+1 −1
Original line number Diff line number Diff line
@@ -705,7 +705,7 @@ class YnlFamily(SpecFamily): 
            return attr.as_bin()



    def _rsp_add(self, rsp, name, is_multi, decoded):

        if is_multi == None:

        if is_multi is None:

            if name in rsp and type(rsp[name]) is not list:

                rsp[name] = [rsp[name]]

                is_multi = True

tools/net/ynl/pyynl/ynl_gen_c.py

+1 −1
Original line number Diff line number Diff line
@@ -397,7 +397,7 @@ class TypeScalar(Type): 
        if 'enum' in self.attr:

            enum = self.family.consts[self.attr['enum']]

            low, high = enum.value_range()

            if low == None and high == None:

            if low is None and high is None:

                self.checks['sparse'] = True

            else:

                if 'min' not in self.checks: