Commit 10e806d3 authored by Jason Yan's avatar Jason Yan Committed by Wolfram Sang
Browse files

i2c: s3c2410: make i2c_s3c_irq_nextbyte() void 



Fix the following coccicheck warning:

drivers/i2c/busses/i2c-s3c2410.c:391:5-8: Unneeded variable: "ret".
Return "0" on line 552

Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent ca562a9c

drivers/i2c/busses/i2c-s3c2410.c

+3 −4
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static const struct platform_device_id s3c24xx_driver_ids[] = { 
};

MODULE_DEVICE_TABLE(platform, s3c24xx_driver_ids);



static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat);

static void i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat);



#ifdef CONFIG_OF

static const struct of_device_id s3c24xx_i2c_match[] = {
@@ -377,11 +377,10 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c) 
/*

 * process an interrupt and work out what to do

 */

static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)

static void i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)

{

	unsigned long tmp;

	unsigned char byte;

	int ret = 0;



	switch (i2c->state) {
@@ -544,7 +543,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) 
	tmp &= ~S3C2410_IICCON_IRQPEND;

	writel(tmp, i2c->regs + S3C2410_IICCON);

 out:

	return ret;

	return;

}



/*