Commit 11047466 authored by Pratyush Yadav's avatar Pratyush Yadav Committed by Andrew Morton
Browse files

test_kho: always print restore status 

Currently the KHO test only prints a message on success, and remains
silent on failure.  This makes it difficult to notice a failing test.  A
failing test is usually more interesting than a successful one.

Always print the test status after attempting restore.

Link: https://lkml.kernel.org/r/20251118181046.23321-1-pratyush@kernel.org


Signed-off-by: default avatarPratyush Yadav <pratyush@kernel.org>
Reviewed-by: default avatarPasha Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: default avatarMike Rapoport (Microsoft) <rppt@kernel.org>
Acked-by: default avatarSeongJae Park <sj@kerneel.org>
Cc: Alexander Graf <graf@amazon.com>
Cc: Pratyush Yadav <pratyush@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent b1551515

lib/test_kho.c

+9 −3
Original line number Diff line number Diff line
@@ -306,7 +306,6 @@ static int kho_test_restore(phys_addr_t fdt_phys) 
	if (err)

		return err;



	pr_info("KHO restore succeeded\n");

	return 0;

}
@@ -319,8 +318,15 @@ static int __init kho_test_init(void) 
		return 0;



	err = kho_retrieve_subtree(KHO_TEST_FDT, &fdt_phys);

	if (!err)

		return kho_test_restore(fdt_phys);

	if (!err) {

		err = kho_test_restore(fdt_phys);

		if (err)

			pr_err("KHO restore failed\n");

		else

			pr_info("KHO restore succeeded\n");



		return err;

	}



	if (err != -ENOENT) {

		pr_warn("failed to retrieve %s FDT: %d\n", KHO_TEST_FDT, err);