Commit 1108d677 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: dwc: Simplify config resource lookup 

If platform_get_resource_byname("config") fails, return error immediately
and unindent the normal path.  No functional change intended.

Link: https://lore.kernel.org/r/20250117235119.712043-1-helgaas@kernel.org


Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 4dbf0155

drivers/pci/controller/dwc/pcie-designware-host.c

+9 −9
Original line number Diff line number Diff line
@@ -436,17 +436,17 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) 
		return ret;



	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config");

	if (res) {

	if (!res) {

		dev_err(dev, "Missing \"config\" reg space\n");

		return -ENODEV;

	}



	pp->cfg0_size = resource_size(res);

	pp->cfg0_base = res->start;



	pp->va_cfg0_base = devm_pci_remap_cfg_resource(dev, res);

	if (IS_ERR(pp->va_cfg0_base))

		return PTR_ERR(pp->va_cfg0_base);

	} else {

		dev_err(dev, "Missing *config* reg space\n");

		return -ENODEV;

	}



	bridge = devm_pci_alloc_host_bridge(dev, 0);

	if (!bridge)