Commit 11119b19 authored by Anshuman Khandual's avatar Anshuman Khandual Committed by Andrew Morton
Browse files

mm/ptdump: replace READ_ONCE() with standard page table accessors 

Replace READ_ONCE() with standard page table accessors i.e pxdp_get()
which anyways default into READ_ONCE() in cases where platform does not
override.  Also convert ptep_get_lockless() into ptep_get() as well.

Link: https://lkml.kernel.org/r/20251001042502.1400726-1-anshuman.khandual@arm.com


Signed-off-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: default avatarDev Jain <dev.jain@arm.com>
Acked-by: default avatarLance Yang <lance.yang@linux.dev>
Acked-by: default avatarSeongJae Park <sj@kernel.org>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent b6c46600

mm/ptdump.c

+5 −5
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ static int ptdump_pgd_entry(pgd_t *pgd, unsigned long addr, 
			    unsigned long next, struct mm_walk *walk)

{

	struct ptdump_state *st = walk->private;

	pgd_t val = READ_ONCE(*pgd);

	pgd_t val = pgdp_get(pgd);



#if CONFIG_PGTABLE_LEVELS > 4 && \

		(defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS))
@@ -54,7 +54,7 @@ static int ptdump_p4d_entry(p4d_t *p4d, unsigned long addr, 
			    unsigned long next, struct mm_walk *walk)

{

	struct ptdump_state *st = walk->private;

	p4d_t val = READ_ONCE(*p4d);

	p4d_t val = p4dp_get(p4d);



#if CONFIG_PGTABLE_LEVELS > 3 && \

		(defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS))
@@ -77,7 +77,7 @@ static int ptdump_pud_entry(pud_t *pud, unsigned long addr, 
			    unsigned long next, struct mm_walk *walk)

{

	struct ptdump_state *st = walk->private;

	pud_t val = READ_ONCE(*pud);

	pud_t val = pudp_get(pud);



#if CONFIG_PGTABLE_LEVELS > 2 && \

		(defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS))
@@ -100,7 +100,7 @@ static int ptdump_pmd_entry(pmd_t *pmd, unsigned long addr, 
			    unsigned long next, struct mm_walk *walk)

{

	struct ptdump_state *st = walk->private;

	pmd_t val = READ_ONCE(*pmd);

	pmd_t val = pmdp_get(pmd);



#if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)

	if (pmd_page(val) == virt_to_page(lm_alias(kasan_early_shadow_pte)))
@@ -121,7 +121,7 @@ static int ptdump_pte_entry(pte_t *pte, unsigned long addr, 
			    unsigned long next, struct mm_walk *walk)

{

	struct ptdump_state *st = walk->private;

	pte_t val = ptep_get_lockless(pte);

	pte_t val = ptep_get(pte);



	if (st->effective_prot_pte)

		st->effective_prot_pte(st, val);