Commit 11194b41 authored by Sam Edwards's avatar Sam Edwards Committed by Ilya Dryomov
Browse files

libceph: reset sparse-read state in osd_fault()



When a fault occurs, the connection is abandoned, reestablished, and any
pending operations are retried. The OSD client tracks the progress of a
sparse-read reply using a separate state machine, largely independent of
the messenger's state.

If a connection is lost mid-payload or the sparse-read state machine
returns an error, the sparse-read state is not reset. The OSD client
will then interpret the beginning of a new reply as the continuation of
the old one. If this makes the sparse-read machinery enter a failure
state, it may never recover, producing loops like:

  libceph:  [0] got 0 extents
  libceph: data len 142248331 != extent len 0
  libceph: osd0 (1)...:6801 socket error on read
  libceph: data len 142248331 != extent len 0
  libceph: osd0 (1)...:6801 socket error on read

Therefore, reset the sparse-read state in osd_fault(), ensuring retries
start from a clean state.

Cc: stable@vger.kernel.org
Fixes: f628d799 ("libceph: add sparse read support to OSD client")
Signed-off-by: default avatarSam Edwards <CFSworks@gmail.com>
Reviewed-by: default avatarIlya Dryomov <idryomov@gmail.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent e84b48d3
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -4281,6 +4281,9 @@ static void osd_fault(struct ceph_connection *con)
		goto out_unlock;
	}

	osd->o_sparse_op_idx = -1;
	ceph_init_sparse_read(&osd->o_sparse_read);

	if (!reopen_osd(osd))
		kick_osd_requests(osd);
	maybe_request_map(osdc);