Unverified Commit 111e2863 authored by Felix Gu's avatar Felix Gu Committed by Mark Brown
Browse files

spi: rockchip-sfc: Fix double-free in remove() callback 



The driver uses devm_spi_register_controller() for registration, which
automatically unregisters the controller via devm cleanup when the
device is removed. The manual call to spi_unregister_controller() in
the remove() callback can lead to a double-free.

And to make sure controller is unregistered before DMA buffer is
unmapped, switch to use spi_register_controller() in probe().

Fixes: 80117099 ("spi: rockchip-sfc: Support pm ops")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260310-sfc-v2-1-67fab04b097f@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ad0e9ac2

drivers/spi/spi-rockchip-sfc.c

+1 −1
Original line number Diff line number Diff line
@@ -711,7 +711,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev) 
		}

	}



	ret = devm_spi_register_controller(dev, host);

	ret = spi_register_controller(host);

	if (ret)

		goto err_register;