Commit 1131e705 authored by Kim Seer Paller's avatar Kim Seer Paller Committed by Jonathan Cameron
Browse files

iio: dac: ad3530r: Fix incorrect masking for channels 4-7 in powerdown mode 



In the current implementation of ad3530r_set_dac_powerdown() function,
the macro AD3530R_OP_MODE_CHAN_MSK(chan->channel) is used to generate
the bitmask for the operating mode of a specific channel. However, this
macro does not account for channels 4-7, which map to the second
register AD3530R_OUTPUT_OPERATING_MODE_1 for the 8 channeled device. As
a result, the bitmask is incorrectly calculated for these channels,
leading to improper configuration of the powerdown mode. Resolve this
issue by adjusting the channel index for channels 4-7 by subtracting 4
before applying the macro. This ensures that the correct bitmask is
generated for the second register.

Fixes: 93583174 ("iio: dac: ad3530r: Add driver for AD3530R and AD3531R")
Signed-off-by: default avatarKim Seer Paller <kimseer.paller@analog.com>
Reviewed-by: default avatarDavid Lechner <dlechner@baylibre.com>
Reviewed-by: default avatarNuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250626-bug_fix-v1-1-eb3c2b370f10@analog.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 24fa6989

drivers/iio/dac/ad3530r.c

+3 −1
Original line number Diff line number Diff line
@@ -166,7 +166,9 @@ static ssize_t ad3530r_set_dac_powerdown(struct iio_dev *indio_dev, 
	      AD3530R_OUTPUT_OPERATING_MODE_0 :

	      AD3530R_OUTPUT_OPERATING_MODE_1;

	pdmode = powerdown ? st->chan[chan->channel].powerdown_mode : 0;

	mask = AD3530R_OP_MODE_CHAN_MSK(chan->channel);

	mask = chan->channel < AD3531R_MAX_CHANNELS ?

	       AD3530R_OP_MODE_CHAN_MSK(chan->channel) :

	       AD3530R_OP_MODE_CHAN_MSK(chan->channel - 4);

	val = field_prep(mask, pdmode);



	ret = regmap_update_bits(st->regmap, reg, mask, val);