Commit 113e9a28 authored by Thorsten Blum's avatar Thorsten Blum Committed by Takashi Iwai
Browse files

ALSA: hda: Improve local variable data type in snd_hda_get_num_devices() 



Use 'int' instead of 'unsigned int' because the local variable 'parm'
can be negative.

While an unsigned integer is harmless in practice due to the implicit
type conversion, it's safer and more idiomatic to use a signed integer
to properly check for -1.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250813103418.164110-2-thorsten.blum@linux.dev


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent aff8436e

sound/hda/common/codec.c

+1 −1
Original line number Diff line number Diff line
@@ -300,7 +300,7 @@ EXPORT_SYMBOL_GPL(snd_hda_get_conn_index); 
unsigned int snd_hda_get_num_devices(struct hda_codec *codec, hda_nid_t nid)

{

	unsigned int wcaps = get_wcaps(codec, nid);

	unsigned int parm;

	int parm;



	if (!codec->dp_mst || !(wcaps & AC_WCAP_DIGITAL) ||

	    get_wcaps_type(wcaps) != AC_WID_PIN)