Commit 11445469 authored by Eric Dumazet's avatar Eric Dumazet Committed by Paolo Abeni
Browse files

net: sock_release_ownership() cleanup 



sock_release_ownership() should only be called by user
owning the socket lock.

After prior commit, we can remove one condition.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent b49d2522

include/net/sock.h

+4 −5
Original line number Diff line number Diff line
@@ -1823,13 +1823,12 @@ static inline bool sock_owned_by_user_nocheck(const struct sock *sk) 


static inline void sock_release_ownership(struct sock *sk)

{

	if (sock_owned_by_user_nocheck(sk)) {

	DEBUG_NET_WARN_ON_ONCE(!sock_owned_by_user_nocheck(sk));

	sk->sk_lock.owned = 0;



	/* The sk_lock has mutex_unlock() semantics: */

	mutex_release(&sk->sk_lock.dep_map, _RET_IP_);

}

}



/* no reclassification while locks are held */

static inline bool sock_allow_reclassification(const struct sock *csk)