Commit 115c0f4d authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

idpf: fix potential use-after-free in idpf_tso() 



skb_cow_head() can change skb->head (and thus skb_shinfo(skb))

We must not cache skb_shinfo(skb) before skb_cow_head().

Fixes: 6818c4d5 ("idpf: add splitq start_xmit")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Joshua Hay <joshua.a.hay@intel.com>
Cc: Alan Brady <alan.brady@intel.com>
Cc: Madhu Chittim <madhu.chittim@intel.com>
Cc: Phani Burra <phani.r.burra@intel.com>
Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>
Cc: Willem de Bruijn <willemb@google.com>
Cc: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Bailey Forrest <bcf@google.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20231103200451.514047-1-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9fc3bc76

drivers/net/ethernet/intel/idpf/idpf_txrx.c

+4 −2
Original line number Diff line number Diff line
@@ -2365,7 +2365,7 @@ static void idpf_tx_splitq_map(struct idpf_queue *tx_q, 
 */

int idpf_tso(struct sk_buff *skb, struct idpf_tx_offload_params *off)

{

	const struct skb_shared_info *shinfo = skb_shinfo(skb);

	const struct skb_shared_info *shinfo;

	union {

		struct iphdr *v4;

		struct ipv6hdr *v6;
@@ -2379,13 +2379,15 @@ int idpf_tso(struct sk_buff *skb, struct idpf_tx_offload_params *off) 
	u32 paylen, l4_start;

	int err;



	if (!shinfo->gso_size)

	if (!skb_is_gso(skb))

		return 0;



	err = skb_cow_head(skb, 0);

	if (err < 0)

		return err;



	shinfo = skb_shinfo(skb);



	ip.hdr = skb_network_header(skb);

	l4.hdr = skb_transport_header(skb);