Commit 116c0bda authored by Zhang Yi's avatar Zhang Yi Committed by Theodore Ts'o
Browse files

ext4: remove ctime/mtime update from ext4_alloc_file_blocks() 



The ctime and mtime update is already handled by file_modified() in
ext4_fallocate(), the caller of ext4_alloc_file_blocks(). So remove the
redundant calls to inode_set_ctime_current() and inode_set_mtime_to_ts()
in ext4_alloc_file_blocks().

Signed-off-by: default avatarZhang Yi <yi.zhang@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20260327102939.1095257-12-yi.zhang@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent c3688d21

fs/ext4/extents.c

+1 −4
Original line number Diff line number Diff line
@@ -4652,13 +4652,10 @@ static int ext4_alloc_file_blocks(struct file *file, loff_t offset, loff_t len, 
		 */

		retries = 0;

		epos = EXT4_LBLK_TO_B(inode, map.m_lblk + ret);

		inode_set_ctime_current(inode);

		if (new_size) {

			if (epos > new_size)

				epos = new_size;

			if (ext4_update_inode_size(inode, epos) & 0x1)

				inode_set_mtime_to_ts(inode,

						      inode_get_ctime(inode));

			ext4_update_inode_size(inode, epos);

			if (epos > old_size)

				pagecache_isize_extended(inode, old_size, epos);

		}