Commit 119736c7 authored by Wolfram Sang's avatar Wolfram Sang
Browse files

i2c: testunit: avoid re-issued work after read message 



The to-be-fixed commit rightfully prevented that the registers will be
cleared. However, the index must be cleared. Otherwise a read message
will re-issue the last work. Fix it and add a comment describing the
situation.

Fixes: c422b6a6 ("i2c: testunit: don't erase registers after STOP")
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
parent bd9f5348

drivers/i2c/i2c-slave-testunit.c

+7 −0
Original line number Diff line number Diff line
@@ -118,6 +118,13 @@ static int i2c_slave_testunit_slave_cb(struct i2c_client *client, 
			queue_delayed_work(system_long_wq, &tu->worker,

					   msecs_to_jiffies(10 * tu->regs[TU_REG_DELAY]));

		}



		/*

		 * Reset reg_idx to avoid that work gets queued again in case of

		 * STOP after a following read message. But do not clear TU regs

		 * here because we still need them in the workqueue!

		 */

		tu->reg_idx = 0;

		break;



	case I2C_SLAVE_WRITE_REQUESTED: