Commit 119e90a3 authored by Maud Spierings's avatar Maud Spierings Committed by Alexandre Belloni
Browse files

rtc: pcf85063: replace dev_err+return with return dev_err_probe 



Replace the dev_err plus return combo with return dev_err_probe() this
actually communicates the error type when it occurs and helps debugging
hardware issues.

Signed-off-by: default avatarMaud Spierings <maudspierings@gocontroll.com>
Link: https://lore.kernel.org/r/20250304-rtc_dev_err_probe-v1-1-9dcc042ad17e@gocontroll.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 2b7cbd98

drivers/rtc/rtc-pcf85063.c

+2 −4
Original line number Diff line number Diff line
@@ -591,10 +591,8 @@ static int pcf85063_probe(struct i2c_client *client) 
	i2c_set_clientdata(client, pcf85063);



	err = regmap_read(pcf85063->regmap, PCF85063_REG_SC, &tmp);

	if (err) {

		dev_err(&client->dev, "RTC chip is not present\n");

		return err;

	}

	if (err)

		return dev_err_probe(&client->dev, err, "RTC chip is not present\n");



	pcf85063->rtc = devm_rtc_allocate_device(&client->dev);

	if (IS_ERR(pcf85063->rtc))