Commit 11b1b8bc authored by Tianchen Ding's avatar Tianchen Ding Committed by Peter Zijlstra
Browse files

sched/eevdf: Always update V if se->on_rq when reweighting 



reweight_eevdf() needs the latest V to do accurate calculation for new
ve and vd. So update V unconditionally when se is runnable.

Fixes: eab03c23 ("sched/eevdf: Fix vruntime adjustment on reweight")
Suggested-by: default avatarAbel Wu <wuyun.abel@bytedance.com>
Signed-off-by: default avatarTianchen Ding <dtcccc@linux.alibaba.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarAbel Wu <wuyun.abel@bytedance.com>
Tested-by: default avatarK Prateek Nayak <kprateek.nayak@amd.com>
Tested-by: default avatarChen Yu <yu.c.chen@intel.com>
Link: https://lore.kernel.org/r/20240306022133.81008-2-dtcccc@linux.alibaba.com
parent ed30a4a5

kernel/sched/fair.c

+2 −3
Original line number Diff line number Diff line
@@ -3790,9 +3790,8 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, 


	if (se->on_rq) {

		/* commit outstanding execution time */

		if (curr)

		update_curr(cfs_rq);

		else

		if (!curr)

			__dequeue_entity(cfs_rq, se);

		update_load_sub(&cfs_rq->load, se->load.weight);

	}