Commit 11c79df9 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Martin K. Petersen
Browse files

scsi: isci: Make most module parameters static 



Most of the module parameters are only used locally in the same C file; so
static them.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Link: https://lore.kernel.org/r/20250309145044.38586-1-linux@treblig.org


Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent b79e4a2d

drivers/scsi/isci/init.c

+7 −7
Original line number Diff line number Diff line
@@ -91,31 +91,31 @@ MODULE_DEVICE_TABLE(pci, isci_id_table); 


/* linux isci specific settings */



unsigned char no_outbound_task_to = 2;

static unsigned char no_outbound_task_to = 2;

module_param(no_outbound_task_to, byte, 0);

MODULE_PARM_DESC(no_outbound_task_to, "No Outbound Task Timeout (1us incr)");



u16 ssp_max_occ_to = 20;

static u16 ssp_max_occ_to = 20;

module_param(ssp_max_occ_to, ushort, 0);

MODULE_PARM_DESC(ssp_max_occ_to, "SSP Max occupancy timeout (100us incr)");



u16 stp_max_occ_to = 5;

static u16 stp_max_occ_to = 5;

module_param(stp_max_occ_to, ushort, 0);

MODULE_PARM_DESC(stp_max_occ_to, "STP Max occupancy timeout (100us incr)");



u16 ssp_inactive_to = 5;

static u16 ssp_inactive_to = 5;

module_param(ssp_inactive_to, ushort, 0);

MODULE_PARM_DESC(ssp_inactive_to, "SSP inactivity timeout (100us incr)");



u16 stp_inactive_to = 5;

static u16 stp_inactive_to = 5;

module_param(stp_inactive_to, ushort, 0);

MODULE_PARM_DESC(stp_inactive_to, "STP inactivity timeout (100us incr)");



unsigned char phy_gen = SCIC_SDS_PARM_GEN2_SPEED;

static unsigned char phy_gen = SCIC_SDS_PARM_GEN2_SPEED;

module_param(phy_gen, byte, 0);

MODULE_PARM_DESC(phy_gen, "PHY generation (1: 1.5Gbps 2: 3.0Gbps 3: 6.0Gbps)");



unsigned char max_concurr_spinup;

static unsigned char max_concurr_spinup;

module_param(max_concurr_spinup, byte, 0);

MODULE_PARM_DESC(max_concurr_spinup, "Max concurrent device spinup");

drivers/scsi/isci/isci.h

+0 −7
Original line number Diff line number Diff line
@@ -473,13 +473,6 @@ static inline void sci_swab32_cpy(void *_dest, void *_src, ssize_t word_cnt) 
		dest[word_cnt] = swab32(src[word_cnt]);

}



extern unsigned char no_outbound_task_to;

extern u16 ssp_max_occ_to;

extern u16 stp_max_occ_to;

extern u16 ssp_inactive_to;

extern u16 stp_inactive_to;

extern unsigned char phy_gen;

extern unsigned char max_concurr_spinup;

extern uint cable_selection_override;



irqreturn_t isci_msix_isr(int vec, void *data);