Commit 11cb461c authored by Cezar Chiru's avatar Cezar Chiru Committed by Andi Shyti
Browse files

i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret < 0. 



Require spaces around '=' and '<'. Add spaces around binary operators.
Enforce error fixing based on checkpatch.pl output on file.
Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
improves usage of ret variable.

Signed-off-by: default avatarCezar Chiru <chiru.cezar.89@gmail.com>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251023120043.8661-2-chiru.cezar.89@gmail.com
parent d3429178

drivers/i2c/algos/i2c-algo-pcf.c

+8 −4
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, 
	struct i2c_algo_pcf_data *adap = i2c_adap->algo_data;

	struct i2c_msg *pmsg;

	int i;

	int ret=0, timeout, status;

	int timeout, status;



	if (adap->xfer_begin)

		adap->xfer_begin(adap->data);
@@ -284,9 +284,10 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, 
		goto out;

	}



	for (i = 0;ret >= 0 && i < num; i++) {

		pmsg = &msgs[i];

	for (i = 0; i < num; i++) {

		int ret;



		pmsg = &msgs[i];

		ret = pcf_doAddress(adap, pmsg);



		/* Send START */
@@ -321,6 +322,9 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, 
			ret = pcf_sendbytes(i2c_adap, pmsg->buf, pmsg->len,

					    (i + 1 == num));

		}



		if (ret < 0)

			goto out;

	}



out: