Unverified Commit 11cba479 authored by Kurt Borja's avatar Kurt Borja Committed by Ilpo Järvinen
Browse files

platform/x86: hp-bioscfg: Fix class device unregistration 



Devices under the firmware_attributes_class do not have unique a dev_t.
Therefore, device_unregister() should be used instead of
device_destroy(), since the latter may match any device with a given
dev_t.

Fixes: a34fc329 ("platform/x86: hp-bioscfg: bioscfg")
Signed-off-by: default avatarKurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250625-dest-fix-v1-1-3a0f342312bb@gmail.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent e1af6f01

drivers/platform/x86/hp/hp-bioscfg/bioscfg.c

+2 −2
Original line number Diff line number Diff line
@@ -1034,7 +1034,7 @@ static int __init hp_init(void) 
	release_attributes_data();



err_destroy_classdev:

	device_destroy(&firmware_attributes_class, MKDEV(0, 0));

	device_unregister(bioscfg_drv.class_dev);



err_unregister_class:

	hp_exit_attr_set_interface();
@@ -1045,7 +1045,7 @@ static int __init hp_init(void) 
static void __exit hp_exit(void)

{

	release_attributes_data();

	device_destroy(&firmware_attributes_class, MKDEV(0, 0));

	device_unregister(bioscfg_drv.class_dev);



	hp_exit_attr_set_interface();

}